shaynhornik commented on PR #3893: URL: https://github.com/apache/iceberg-python/pull/3893#issuecomment-5533435497
Agreed that one LICENSE has to be right for both artifacts, which is why each entry names both layouts rather than replacing one path with the other. I built both from this branch to confirm (`python -m build --sdist --wheel`): - **sdist** (`pyiceberg-0.12.0.tar.gz`): the Thrift and Hive code is under `vendor/fb303/` and `vendor/hive_metastore/`, matching "located in vendor/… in the source distribution". - **wheel** (`pyiceberg-0.12.0-cp311-…whl`): `setup.py`'s `package_dir` remaps them, so they land as top-level `fb303/` and `hive_metastore/` with no `vendor/` directory at all, matching "shipped as the top-level … package in binary distributions". - The identical LICENSE text is at the sdist root and at `pyiceberg-0.12.0.dist-info/licenses/LICENSE` in the wheel. - The Cython entry is scoped to "binary distributions" because the sdist excludes the generated `decoder_fast.c` (`MANIFEST.in`) and ships only the `.pyx`; the wheel's compiled `.so` is where the Cython runtime code appears. Happy to reword if you'd prefer a different phrasing for the two layouts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
