kbendick commented on a change in pull request #2081:
URL: https://github.com/apache/iceberg/pull/2081#discussion_r556251343
##########
File path: api/src/main/java/org/apache/iceberg/util/BinaryUtil.java
##########
@@ -28,12 +28,23 @@
private BinaryUtil() {
}
+ private static final ByteBuffer EMPTY_BYTE_BUFFER = ByteBuffer.allocate(0);
Review comment:
I can make this lazily instantiated if we care. Or just return a new
empty byte buffer instance every time in the function, but seems unnecessary to
have all of those allocations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
