kbendick commented on a change in pull request #2081:
URL: https://github.com/apache/iceberg/pull/2081#discussion_r556359204
##########
File path: api/src/main/java/org/apache/iceberg/util/BinaryUtil.java
##########
@@ -28,12 +28,23 @@
private BinaryUtil() {
}
+ private static final ByteBuffer EMPTY_BYTE_BUFFER = ByteBuffer.allocate(0);
+
/**
- * Truncates the input byte buffer to the given length
+ * Truncates the input byte buffer to the given length.
+ * <p>
+ * We allow for a length of zero so that rows with empty string can be
evaluated.
+ * Partition specs still cannot be created with a length of zero due to a
constraint
+ * when parsing column truncation specs in org.apache.iceberg.MetricsModes.
Review comment:
Pushing a version using @code. Thanks for the tip.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
