nssalian commented on code in PR #1607:
URL: https://github.com/apache/iceberg-go/pull/1607#discussion_r3937015307
##########
visitors.go:
##########
@@ -802,54 +884,79 @@ const sanitizedLiteralMask = "(redacted)"
// predicates (IN / NOT IN) keep their arity so the operation is not
// misrepresented, but the members are masked.
func SanitizeExpression(expr BooleanExpression) (BooleanExpression, error) {
- return VisitExpr(expr, sanitizeVisitor{})
+ res, err := VisitExpr(expr, sanitizeVisitor{})
+ if err != nil {
+ return nil, err
+ }
+
+ return res.expr, nil
+}
+
+// sanitizedResult is the masked expression plus whether its subtree held a
non-serializable term.
+type sanitizedResult struct {
+ expr BooleanExpression
+ hasUnserializable bool
Review Comment:
Added the one-line note - the collapse is over-broad (drops the serializable
siblings from the report) but never AlwaysFalse, matching the bbox convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
