nssalian commented on code in PR #1607:
URL: https://github.com/apache/iceberg-go/pull/1607#discussion_r3937599266
##########
schema.go:
##########
@@ -524,6 +524,33 @@ func (s *Schema) accessorForField(id int) (accessor, bool)
{
return acc, ok
}
+// columnPathSegments returns the own-name path segments from the top-level
column down to id, so a name containing '.' stays one segment.
+func (s *Schema) columnPathSegments(id int) []string {
+ idToField, err := s.lazyIDToField()
Review Comment:
Added TestColumnPathSegments in the root package asserting
columnPathSegments returns ["a.b"] for a top-level a.b and
["wrap.per","pay.load"] for the nested case.
re the Lossy NOT sanitization in visitors.go: Kept this as the documented
tradeoff for now - the collapse is over-broad but never AlwaysFalse, and it
only affects the ScanReport filter string (never query results), so I'd rather
not re-architect the sanitizer for a report-only nit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
