manuzhang commented on code in PR #873: URL: https://github.com/apache/iceberg-cpp/pull/873#discussion_r3946331474
########## src/iceberg/type_fwd.h: ########## @@ -24,6 +24,8 @@ /// you can include this instead of the "full" headers to help reduce compile /// times. +#include <memory> + Review Comment: Fixed in d82d9e2. I moved FileScanTaskIterator out of type_fwd.h into a dedicated public header that includes the complete Iterator definition. Both public API headers now include that header, and Iterator itself remains forward-declared in type_fwd.h. I also added a regression test that destroys FileScanTaskIterator while FileScanTask is still incomplete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
