manuzhang commented on code in PR #873:
URL: https://github.com/apache/iceberg-cpp/pull/873#discussion_r3981388514
##########
src/iceberg/manifest/manifest_reader.h:
##########
@@ -42,13 +43,23 @@ class ICEBERG_EXPORT ManifestReader {
virtual ~ManifestReader() = default;
/// \brief Read all manifest entries in the manifest file.
- ///
- /// TODO(gangwu): provide a lazy-evaluated iterator interface for better
performance.
virtual Result<std::vector<ManifestEntry>> Entries() = 0;
/// \brief Read only live (non-deleted) manifest entries.
virtual Result<std::vector<ManifestEntry>> LiveEntries() = 0;
+ /// \brief Lazily read manifest entries.
+ ///
+ /// Implementations using SupportsManifestEntryIteration stream entries
lazily. Other
+ /// implementations are adapted from Entries() for compatibility.
+ Result<std::unique_ptr<Iterator<ManifestEntry>>> EntriesIterator();
Review Comment:
I renamed Iterator and its subclasses to *Stream to be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
