superdiaodiao commented on PR #17464: URL: https://github.com/apache/iceberg/pull/17464#issuecomment-5584856406
Both done in ad04f30 — table-side test removed, extra blank line gone. Before removing it I checked the view side still earns its place, since the two tests looked symmetric. It does: dropping the guard from `HiveViewOperations` still fails `TestHiveViewCommits`, because that assertion now calls `checkCurrentMetadataLocation` directly rather than through reflection, and the method is package-private to the same package. So the view test distinguishes the fix and the table one did not — exactly the asymmetry you spotted. Coverage after the change: - `TestBaseMetastoreTableOperations` — null-metadata handling on the table path, in the package that owns it - `TestHiveViewCommits` — the view path end-to-end, fails without the guard - `TestHiveCommits` — untouched Hive commit behaviour, minus the test that proved nothing ``` TestBaseMetastoreTableOperations tests=2 failures=0 TestHiveCommits tests=16 failures=0 TestHiveViewCommits tests=13 failures=0 ./gradlew spotlessCheck passed ``` `spotlessApply` also dropped a now-unused `java.util.Map` import from the core test, which is in the same commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
