pvary commented on code in PR #17464:
URL: https://github.com/apache/iceberg/pull/17464#discussion_r3957608579
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java:
##########
@@ -596,6 +600,55 @@ private void concurrentCommitAndThrowException(
.persistTable(any(), anyBoolean(), any());
}
+ /**
+ * Pins the table-specific doRefresh wiring for a never-persisted table: a
CREATE TABLE commit
+ * that fails with a non-specific exception must resolve the commit status
cleanly instead of
+ * NPE-ing in checkCurrentMetadataLocation (#17462). Pins the Hive-specific
doRefresh wiring:
+ * refreshing a never-persisted table yields null metadata. The
null-metadata handling itself is
+ * covered by TestBaseMetastoreTableOperations.
+ */
+ @Test
+ public void
testThriftExceptionUnknownStateOnCreateCommitWhenTableNeverPersisted()
Review Comment:
This tests now succeeds with and without the change, so we can remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
