anoopj commented on code in PR #18021:
URL: https://github.com/apache/iceberg/pull/18021#discussion_r3963417411
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -123,10 +132,13 @@ private void incrementSkipCount(FileContent content) {
}
private CloseableIterable<TrackedFile> open() {
+ InputFile file = ManifestFiles.newInputFile(io, manifest);
FileFormat format = FileFormat.fromFileName(file.location());
Preconditions.checkArgument(
format != null, "Cannot determine format of manifest: %s",
file.location());
+ scanMetrics.scannedDataManifests().increment();
Review Comment:
Since we are doing the increment without checking the content type, we are
also incrementing the counter for root. This is intentional. Also we explicitly
reject `ManifestContent.DELETES` in the builder, since v4 only has colocated
manifests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
