anoopj commented on code in PR #18021:
URL: https://github.com/apache/iceberg/pull/18021#discussion_r3963468770
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -123,10 +132,13 @@ private void incrementSkipCount(FileContent content) {
}
private CloseableIterable<TrackedFile> open() {
+ InputFile file = ManifestFiles.newInputFile(io, manifest);
FileFormat format = FileFormat.fromFileName(file.location());
Preconditions.checkArgument(
format != null, "Cannot determine format of manifest: %s",
file.location());
+ scanMetrics.scannedDataManifests().increment();
Review Comment:
Note to reviewers: we are incrementing the counter inside `open()`: this is
probably the best place to do this, but it also means a double read of the
iterator will increment the counter twice. The other alternative to increment
the counter really early (say in the builder or constructor): that didn't look
right either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
