mattfaltyn commented on PR #1988: URL: https://github.com/apache/iceberg-go/pull/1988#issuecomment-5608145588
> I'd move the max-field-id scan to the write side. Implemented in c9bae41. Parsing now preserves the catalog-visible counter, while `UpdateSpec` and `MetadataBuilder.AddPartitionSpec` share a history-aware allocation floor. A stale `999` requirement still matches the catalog and the new field receives `1001`. > If we assert that update's AssertLastAssignedPartitionID requirement equals 999 here, this test goes red and surfaces the desync. Covered, together with explicit fixture guards and a two-spec historical case. The V1 missing-ID re-marshal path remains covered by the existing test; stale-counter re-marshalling is no longer part of the fix. Full tests, targeted race coverage, assert tests, vet, and lint are clean. Thanks for the sharp review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
