kevinjqliu opened a new pull request, #3927: URL: https://github.com/apache/iceberg-python/pull/3927
Follow up to #3924. # Rationale for this change Two small things after moving CI to Hive 4.2.1: - Docs: `hive.hive2-compatible` now also selects the legacy thrift calls, so document it as "set this if you're on Hive 2". Hive 3+ works by default. - Lock: set `operationType=NO_TXN` on the commit lock. Hive 2.1.0 rejects a lock component left at the default `UNSET` (HMS bug, relaxed in 2.1.1), which broke every commit on that version. Every other version accepts `NO_TXN`. Related: #1222, #1653 # Are these changes tested? Ran the catalog against a metastore for each Hive line: create, load, list, append, rename, drop. | Hive | setting | result | |-------|----------|--------| | 2.0.0 | flag on | pass | | 2.1.0 | flag on | pass | | 2.3.2 | flag on | pass | | 3.1.3 | default | pass | | 4.0.0 | default | pass | | 4.0.1 | default | pass | | 4.1.0 | default | pass | | 4.2.1 | default | pass | The wrong setting fails right away with `Invalid method name`, so a misconfig is obvious. Integration tests pass against 4.2.1. # Are there any user-facing changes? Yes. Since #3924, Hive 2.0-2.2 users need `hive.hive2-compatible: true` (2.3 has both sets of calls but still needs the flag for timestamptz columns). Commits now work on Hive 2.1.0. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
