kevinjqliu commented on code in PR #3927:
URL: https://github.com/apache/iceberg-python/pull/3927#discussion_r3992137363
##########
pyiceberg/catalog/hive.py:
##########
@@ -506,8 +507,16 @@ def load_view(self, identifier: str | Identifier) -> View:
raise NotImplementedError
def _create_lock_request(self, database_name: str, table_name: str) ->
LockRequest:
+ # Iceberg commits are not executed within a Hive transaction, so the
lock component uses operationType=NO_TXN.
+ # Setting it explicitly also matters for Hive 2.1, which rejects a
lock component left at the default UNSET
Review Comment:
```suggestion
# Setting it explicitly also matters for Hive 2.1.0, which rejects a
lock component left at the default UNSET
# operation type. Hive 2.1.1 relaxed this validation:
#
https://github.com/apache/hive/blob/rel/release-2.1.1/metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java#L939-L947
```
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
