alexanderbianchi commented on code in PR #3000: URL: https://github.com/apache/iceberg-rust/pull/3000#discussion_r3997203771
########## crates/integrations/datafusion/src/options.rs: ########## @@ -0,0 +1,107 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::HashMap; + +use datafusion::catalog::Session as DFSession; +use iceberg::SessionContext; +use iceberg::sensitive::SensitiveString; + +/// Iceberg-specific DataFusion options. +/// +/// It does deliberately not implement [`ExtensionOptions`](datafusion::config::ExtensionOptions) +/// and [`ConfigExtension`](datafusion::config::ConfigExtension) to avoid +/// plain-string handling of credential values and prevent SQL users from +/// setting unverified authentication properties such as: +/// +/// ```sql +/// SET iceberg.identity = 'alice'; +/// ``` +#[derive(Clone, Debug, Default)] +pub struct IcebergOptions { Review Comment: > By using SessionContext directly, a user could override that session ID and end up sharing the same auth sessions for different tenants. I'm a bit confused with this one - are you saying like a case where an end user has direct access to the datafusion session? I suppose I don't know how every company exposes datafusion but generally a session is going to be something that whatever service/library wrapper around datafusion will handle. There's tons of session properties that you wouldn't want exposed to end users (our's are not). ########## crates/integrations/datafusion/src/options.rs: ########## @@ -0,0 +1,107 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::HashMap; + +use datafusion::catalog::Session as DFSession; +use iceberg::SessionContext; +use iceberg::sensitive::SensitiveString; + +/// Iceberg-specific DataFusion options. +/// +/// It does deliberately not implement [`ExtensionOptions`](datafusion::config::ExtensionOptions) +/// and [`ConfigExtension`](datafusion::config::ConfigExtension) to avoid +/// plain-string handling of credential values and prevent SQL users from +/// setting unverified authentication properties such as: +/// +/// ```sql +/// SET iceberg.identity = 'alice'; +/// ``` +#[derive(Clone, Debug, Default)] +pub struct IcebergOptions { Review Comment: > By using SessionContext directly, a user could override that session ID and end up sharing the same auth sessions for different tenants. I'm a bit confused with this one - are you saying like a case where an end user has direct access to the datafusion session? I suppose I don't know how every company exposes datafusion but generally a session is going to be something that whatever service/library wrapper around datafusion will handle. There's tons of session properties that you wouldn't want exposed to end users (our's are not). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
