alexanderbianchi commented on code in PR #3000:
URL: https://github.com/apache/iceberg-rust/pull/3000#discussion_r3997230432
##########
crates/integrations/datafusion/src/options.rs:
##########
@@ -43,10 +45,78 @@ pub struct IcebergOptions {
pub credentials: HashMap<String, SensitiveString>,
}
+impl ConfigExtension for IcebergOptions {
+ const PREFIX: &'static str = "iceberg";
+}
+
+impl ExtensionOptions for IcebergOptions {
Review Comment:
https://docs.rs/datafusion/latest/datafusion/config/trait.ConfigExtension.html
There is a macro to help FYI, not sure if it applies here.
Although I do wonder - could we leave `set` intentionally unimplemented so
you can only do `with_extension`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
