LouisDeconinck opened a new pull request, #18097: URL: https://github.com/apache/iceberg/pull/18097
Part of #16445 All APIs tagged `@deprecated ... will be removed in 1.12.0` have already been removed on main. This PR removes the remaining code path documented for removal in 1.12: `DynamicCommitter`'s per-checkpoint `List<CommitRequest>` handling. `DynamicCommitter` grouped multiple `CommitRequest`s per (table, branch, checkpoint) triplet only to process Flink state from releases before 1.11, where the upstream `DynamicWriteResultAggregator` emitted multiple committables per checkpoint. The code comment scheduled this for removal in 1.12, since upgrading through 1.11 migrates the state to a single commit request per checkpoint. Changes: - `commit()` now tracks a single `CommitRequest<DynamicCommittable>` per checkpoint (matching `IcebergCommitter`) and fails fast via `Preconditions.checkState` if a duplicate is received, instead of silently overwriting it and later signaling it as committed without its data files being committed. - `commitPendingRequests` iterates a single request per checkpoint directly. - Tests `testTableBranchAtomicCommitForAppendOnlyData` and `testCommitDeltaTxnWithAppendFiles` now pack the multiple delta manifests into one `DynamicCommittable`, preserving the same commit coverage. - Applied identically to Flink 1.20, 2.1, 2.2 and 2.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
