aiborodin commented on code in PR #18097:
URL: https://github.com/apache/iceberg/pull/18097#discussion_r4044190527
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java:
##########
@@ -222,24 +220,22 @@ private static long getMaxCommittedCheckpointId(
private void commitPendingRequests(
Table table,
String branch,
- NavigableMap<Long, List<CommitRequest<DynamicCommittable>>>
commitRequestMap,
+ NavigableMap<Long, CommitRequest<DynamicCommittable>> commitRequestMap,
String newFlinkJobId,
String operatorId)
throws IOException {
long checkpointId = commitRequestMap.lastKey();
List<ManifestFile> manifests = Lists.newArrayList();
NavigableMap<Long, List<WriteResult>> pendingResults = Maps.newTreeMap();
Review Comment:
This should be simplified to `NavigableMap<Long, WriteResult>` and the loop
below should use the `WriteResult.Builder` to merge multiple `WriteResult`s
from each `FlinkManifestUtil.readCompletedFiles()` call. Every method down the
call stack should accept this simplified collection: `replacePartitions`,
`commitDeltaTxn`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
