xanderbailey opened a new pull request, #3236: URL: https://github.com/apache/iceberg-rust/pull/3236
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Working towards: https://github.com/apache/iceberg-rust/issues/2034 ## What changes are included in this PR? I missed this in the first implementation of encryption. We have tamper proofing built into the encryption spec in the form of the file length on the `StandardKeyMetadata` which we previously were neither reading or writing. The perhaps controversial part of this PR is changing `FileWrite::close` to return `FileMetadata`, this makes it very easy to get the number of written bytes out of the file writer and into the `StandardKeyMetadata` <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## AI Disclosure <!-- https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
