xanderbailey commented on code in PR #3236:
URL: https://github.com/apache/iceberg-rust/pull/3236#discussion_r4024626186
##########
crates/iceberg/src/puffin/writer.rs:
##########
@@ -117,12 +117,11 @@ impl PuffinWriter {
Ok(())
}
- /// Finalizes the Puffin file
- pub async fn close(mut self) -> Result<()> {
+ /// Finalizes the Puffin file and returns its stored size.
+ pub async fn close(mut self) -> Result<io::FileMetadata> {
Review Comment:
[d5f2e24](https://github.com/apache/iceberg-rust/pull/3236/commits/d5f2e24ed40070e995b789b14c3120540e287bde)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
