singhpk234 commented on code in PR #18151:
URL: https://github.com/apache/iceberg/pull/18151#discussion_r4039680409
##########
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##########
@@ -44,6 +44,12 @@ public class GCPProperties implements Serializable {
public static final String GCS_ENCRYPTION_KEY = "gcs.encryption-key";
public static final String GCS_USER_PROJECT = "gcs.user-project";
+ /**
+ * Cloud KMS key resource name for CMEK server-side encryption. Mutually
exclusive with {@link
+ * #GCS_ENCRYPTION_KEY} (CSEK).
+ */
+ public static final String GCS_KMS_KEY_NAME = "gcs.kms-key-name";
Review Comment:
i would really like them to be prefixed with sse ...
like s3 does, s3.sse.<>
this will get more and more tricky as we CSE in... but we already have the
key named this way
let me add some folks from google in this thread as well, if they have
better suggestion on the name !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
