munendrasn commented on code in PR #18151:
URL: https://github.com/apache/iceberg/pull/18151#discussion_r4039768116
##########
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##########
@@ -44,6 +44,12 @@ public class GCPProperties implements Serializable {
public static final String GCS_ENCRYPTION_KEY = "gcs.encryption-key";
public static final String GCS_USER_PROJECT = "gcs.user-project";
+ /**
+ * Cloud KMS key resource name for CMEK server-side encryption. Mutually
exclusive with {@link
+ * #GCS_ENCRYPTION_KEY} (CSEK).
+ */
+ public static final String GCS_KMS_KEY_NAME = "gcs.kms-key-name";
Review Comment:
Thanks @singhpk234 for the review. On the naming, I used current naming in
gcp as reference
[encryptionKey](https://github.com/apache/iceberg/blob/e9f78e956dfd8c47992b62d2744ceaf83bd934ec/gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSOutputStream.java#L108)
is named as `gcp.encryption-key` and same for decryptionKey.
I can rename to follow aws s3 naming convention, if we are aligned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
