RussellSpitzer commented on code in PR #17783: URL: https://github.com/apache/iceberg/pull/17783#discussion_r4057696536
########## format/spec.md: ########## @@ -1416,6 +1417,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify deleted rows in a collection of data files by one or more column values, and may optionally contain additional columns of the deleted row. +Equality delete files must not be added to v4 tables. Equality deletes cannot be added as an entry to a v4 manifest. Equality delete files referenced by v2 or v3 delete manifests must still be applied in a v4 table. Moving entries covered by an equality delete to a v4 manifest requires applying the deletes and writing a new data file entry. Review Comment: If we have to add something here, and I don't think we do since there is no valid way to write a new equality delete entry via the spec, maybe "An equality delete entry cannot be moved into a V4 Manifest, it must either be converted or resolved" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
