huaxingao commented on code in PR #17783: URL: https://github.com/apache/iceberg/pull/17783#discussion_r4057687632
########## format/spec.md: ########## @@ -1416,6 +1417,8 @@ The rows in the delete file must be sorted by `file_path` then `pos` to optimize Equality delete files identify deleted rows in a collection of data files by one or more column values, and may optionally contain additional columns of the deleted row. +Equality delete files must not be added to v4 tables. Equality deletes cannot be added as an entry to a v4 manifest. Equality delete files referenced by v2 or v3 delete manifests must still be applied in a v4 table. Moving entries covered by an equality delete to a v4 manifest requires applying the deletes and writing a new data file entry. Review Comment: This wording came from https://github.com/apache/iceberg/pull/17783#discussion_r3844687172 ########## format/spec.md: ########## @@ -1913,6 +1916,12 @@ Reading v4 metadata: * Relative paths must be resolved against the table location before use (see [Path Resolution](#path-resolution)) * When `location` is omitted, the table location must be provided (see [Table Location Specification](#table-location-specification)) +Row-level delete changes: + +* Equality delete files must not be added to v4 tables and equality deletes cannot be added as an entry to a v4 manifest +* Readers must continue to apply equality deletes for v2 and v3 tables and for equality deletes carried over into upgraded v4 tables +* Upgrading a v2 or v3 table to v4 is metadata-only and does not rewrite data or delete files Review Comment: I think we need to keep this. It is item 3 of the vote proposal: upgrading a v2/v3 table to v4 is metadata-only, with no synchronous rewrite of data or delete files, and converting equality deletes to DVs is optional. https://www.mail-archive.com/[email protected]/msg14669.html Without it, someone could read "new equality deletes are not allowed in v4" as "upgrade must get rid of the existing ones", which is not what we voted on. v3 has the same kind of bullet: "Existing position delete files are valid in tables that have been upgraded from v2". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
