JeonDaehong commented on PR #18027: URL: https://github.com/apache/iceberg/pull/18027#issuecomment-5761170523
Thanks @nastra, and thanks @pvary for carrying the review this far. Addressed the three nits: both test helpers are now `positionsInRange`, and the redundant comment is gone. `org.apache.iceberg.deletes` is 66 tests, no failures. Once this is merged I will open the backport to Spark 3.5, 4.0 and 4.1 - `ColumnarBatchUtil` is byte-identical across those directories, so it should be a mechanical follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
