JeonDaehong commented on code in PR #18027:
URL: https://github.com/apache/iceberg/pull/18027#discussion_r4037348989
##########
core/src/main/java/org/apache/iceberg/deletes/EmptyPositionDeleteIndex.java:
##########
@@ -48,6 +51,15 @@ public boolean isEmpty() {
return true;
}
+ @Override
+ public void forEachInRange(long posStart, long posEnd, LongConsumer
consumer) {
+ Preconditions.checkArgument(
Review Comment:
Renamed in the interface and both implementations.
Thanks to Peter for the clarification -- keeping `forEachInRange()`. The
predicate is probably moot now; let me know if you still want it.
##########
core/src/main/java/org/apache/iceberg/deletes/EmptyPositionDeleteIndex.java:
##########
@@ -48,6 +51,15 @@ public boolean isEmpty() {
return true;
}
+ @Override
+ public void forEachInRange(long posStart, long posEnd, LongConsumer
consumer) {
+ Preconditions.checkArgument(
Review Comment:
Renamed in the interface and both implementations.
Thanks to Peter for the clarification -- keeping `forEachInRange()`. The
predicate is probably moot now; let me know if you still want it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
