rdblue commented on a change in pull request #2055:
URL: https://github.com/apache/iceberg/pull/2055#discussion_r559030487
##########
File path: site/docs/spec.md
##########
@@ -305,11 +321,14 @@ The schema of a manifest file is a struct called
`manifest_entry` with the follo
| _optional_ | _optional_ | **`131 key_metadata`** | `binary`
| Implementation-specific key metadata for encryption |
| _optional_ | _optional_ | **`132 split_offsets`** | `list<133:
long>` | Split offsets for the data file. For example, all row group
offsets in a Parquet file. Must be sorted ascending |
| | _optional_ | **`135 equality_ids`** | `list<136:
int>` | Field ids used to determine row equality in equality delete
files. Required when `content=2` and should be null otherwise. Fields with ids
listed in this column must be present in the delete file |
+| _optional_ | _optional_ | **`140 sort_order_id`** | `int`
| ID representing sort order for this file [2]. |
Notes:
1. Single-value serialization for lower and upper bounds is detailed in
Appendix D.
+2. If sort order ID is missing or unknown, then the order is assumed to be
unsorted. Only data files and equality delete files could have valid sort
orders, and [position deletes](#position-delete-files) are required to be
sorted by file and position. The manifest should not be written with an order
ID for position delete files, and readers must ignore this field for those
files.
Review comment:
How about "only data files and equality delete files should be written
with a non-null order id. "Position deletes are required to be sorted by file
and position, not a table order, and should set sort order id to null".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
