danielcweeks commented on code in PR #18203:
URL: https://github.com/apache/iceberg/pull/18203#discussion_r4074258292
##########
core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java:
##########
@@ -108,6 +110,17 @@ public String register(Namespace ns) {
return SLASH.join("v1", prefix, "namespaces", pathEncode(ns), "register");
}
+ public String unregister(TableIdentifier ident) {
+ return SLASH.join(
+ "v1",
+ prefix,
+ "namespaces",
+ pathEncode(ident.namespace()),
+ "tables",
+ RESTUtil.encodeString(ident.name()),
Review Comment:
```suggestion
RESTUtil.encodePathSegment(ident.name())),
```
This is a path segment and needs the appropriate encoding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
