danielcweeks commented on code in PR #18203:
URL: https://github.com/apache/iceberg/pull/18203#discussion_r4074415756
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##########
@@ -594,6 +600,63 @@ public void testConcurrentCommit() throws IOException {
"Failed to load table db.table from catalog test_jdbc_catalog:
dropped by another process");
}
+ @Test
+ public void testUnregisterRetriesAfterConcurrentCommit() {
Review Comment:
These two tests don't make sense to me. We should just be testing the
unregister functionality in isolation. I don't think concurrent commit is any
different from just validating that the table no longer exists (loading the
table doesn't start any sort of transaction, so this is more performative than
practical)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
