Revanth14 commented on PR #2024: URL: https://github.com/apache/iceberg-go/pull/2024#issuecomment-5784944591
> Both of the things I flagged last round are in now, thanks for tightening it. The precedence paragraph on `ADLSManagedIdentityEnabled` reads right, and the `DefaultAzureCredential` wording no longer implies managed identity is otherwise unreachable. You also caught two pre-existing doc bugs while you were in there (per-account vs per-host connection string, exact-match SAS hostname), which is a nice bonus. > > I left a few small wording notes inline, all optional. The only one I'd genuinely like to see is a short cross-client divergence note in the website section itself, mirroring the "cross-client parity" blockquote under REST metrics. The godoc comments capture the divergence, but a website-only reader doesn't see it, and that's the whole point of the PR. > > Happy to approve once you've had a look. None of it blocks. Thanks for the review! Added the cross-client parity note to the website’s ADLS section, including the PyIceberg docs link, and addressed the inline wording suggestions. @laskoviymishka -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
