KranzL commented on PR #2041: URL: https://github.com/apache/iceberg-go/pull/2041#issuecomment-5804068494
All threads above are answered. 30ffe36 cleans up atomic outputs on failure, shares the per-group apply blocks through two helpers, narrows the context-error substitution and clamps the errgroup limit. 50480ae renames the option to MaxConcurrentGroups with cross-referenced docs. ad900a5 hardens the tests. #2039 is approved but not merged, so this still carries its commits; I will rebase onto main and drop the dependency sentence once it lands, which also removes the two arrow_scanner threads from this diff. BenchmarkRewriteDataFilesGroupConcurrency -count=5 passes after the rename; the evidence table is unchanged because the success path is untouched and the rerun box was loaded (load 25 on 11 cores). go test ./table/... -race -count=1 passes (table 41.8s, compaction 21.0s, dv 3.7s, internal 3.3s, substrait 2.7s); make lint reports 0 issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
