dustinCodes84600 commented on PR #2041: URL: https://github.com/apache/iceberg-go/pull/2041#issuecomment-5821818986
`cleanupAtomicRewriteOutputs` gets the already-canceled caller context, so an FS factory that honors cancellation can fail before deleting outputs. The cancellation test only checks returned error; worth also asserting files are removed and probably doing cleanup with `context.WithoutCancel` plus its own timeout. to keep the cancellation paths straight, I made a visual walkthrough while reading this PR: https://flyovers.dev/flyover/ddd0b368-9cd0-4a0d-831c-03d0867c9ed5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
