rdblue commented on code in PR #18248:
URL: https://github.com/apache/iceberg/pull/18248#discussion_r4108391909
##########
core/src/test/java/org/apache/iceberg/V4TestComparators.java:
##########
@@ -94,9 +94,7 @@ private static <T extends Comparable<T>> Comparator<T>
natural() {
.thenComparing(Tracking::dvSnapshotId, natural())
.thenComparing(Tracking::firstRowId, natural())
.thenComparing(Tracking::deletedPositions, BYTES)
- .thenComparing(Tracking::replacedPositions, BYTES)
- .thenComparing(Tracking::manifestLocation, natural())
- .thenComparingLong(Tracking::manifestPos));
+ .thenComparing(Tracking::replacedPositions, BYTES));
Review Comment:
I don't think so. It's more confusing that they were checked, I think. It
took me a bit to figure out why tests were failing even though all of the data
in the failure message matched!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
