rdblue commented on code in PR #17960:
URL: https://github.com/apache/iceberg/pull/17960#discussion_r4108647535
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -118,7 +118,12 @@ public static void validate(Map<String, String> props,
Schema schema) {
* @return a metrics config for the given table
*/
public static MetricsConfig forTable(Table table) {
Review Comment:
Yes, this is the correct method. The only calls to `from` are from this
class and test classes where we don't have a `Table` instance. We should
probably switch those over to mocks and deprecate the `from` method at some
point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
