gaborkaszab commented on code in PR #16025: URL: https://github.com/apache/iceberg/pull/16025#discussion_r4119608029
########## format/spec.md: ########## @@ -144,8 +147,11 @@ Version 4 of the Iceberg spec adds support for relative locations in metadata, e * **Schema** -- Names and types of fields in a table. * **Partition spec** -- A definition of how partition values are derived from data fields. * **Snapshot** -- The state of a table at some point in time, including the set of all data files. -* **Manifest list** -- A file that lists manifest files; one per snapshot. -* **Manifest** -- A file that lists data or delete files; a subset of a snapshot. +* **Snapshot root** -- The per-snapshot file that tracks a snapshot's manifests; a manifest list (v1-v3) or a root manifest (v4). +* **Manifest list** -- (v1-v3 only) A file that lists manifest files; one per snapshot. +* **Root manifest** -- (v4+) A manifest that can reference data files, data manifests, and delete manifests; one per snapshot. Review Comment: I see there is a section below that describes manifest types and mentions delete manifest for v2-3. I'm wondering if we should articulate here some way that us delete manifest referred by the root manifest is written pre-v4. Maybe the same way as with other concepts here say `(v2-v3 only)` for them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
