kbendick commented on a change in pull request #2102:
URL: https://github.com/apache/iceberg/pull/2102#discussion_r559399986
##########
File path: core/src/main/java/org/apache/iceberg/util/ArrayUtil.java
##########
@@ -92,6 +94,8 @@ private ArrayUtil() {
}
/**
+ * <p>The code from `org.apache.commons:commons-lang3`
Review comment:
Nit: I don't think you need an initial `<p>` tag.
What I've seen elsewhere in the code base is that the first line is written
without `<p>`, and then subsequent paragraphs have a `<p>` tag between them
where the `<p>` tag is on its own line. We tend to not use closing `</p>` tags
as the java doc specification doesn't require them.
So here we would have
```java
/**
* This code is borrowed from `org.apache.commons:commons-lang3`.
* <p>
* Converts an array of object Bytes to primitives.
* <p>
*/
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
