pan3793 commented on a change in pull request #2102: URL: https://github.com/apache/iceberg/pull/2102#discussion_r560619862
########## File path: LICENSE ########## @@ -299,3 +299,13 @@ This product includes code from Delta Lake. Copyright: 2020 The Delta Lake Project Authors. Home page: https://delta.io/ License: https://www.apache.org/licenses/LICENSE-2.0 + +-------------------------------------------------------------------------------- + +This product includes code from Apache Commons. + +* Core ArrayUtil. + +Copyright: 2020 The Apache Software Foundation +Home page: https://commons.apache.org/ +License: https://www.apache.org/licenses/LICENSE-2.0 Review comment: Sure. ########## File path: core/src/main/java/org/apache/iceberg/util/SerdeUtil.java ########## @@ -28,14 +28,14 @@ import java.nio.charset.StandardCharsets; import java.util.Base64; -public class SerializationUtil { +public class SerdeUtil { - private SerializationUtil() { + private SerdeUtil() { Review comment: Not realized there is a `SerializationUtil` in `mr` module at begin, so create a new `SerdeUtil` in `core`. I will revert the name changed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
