rambleraptor commented on code in PR #118: URL: https://github.com/apache/terraform-provider-iceberg/pull/118#discussion_r4127978716
########## docs/index.md: ########## @@ -46,6 +46,36 @@ Use Terraform to interact with Iceberg REST Catalog instances. ### Optional - `headers` (Map of String, Sensitive) The headers to use for authentication. +- `sigv4_access_key_id` (String, Sensitive) Access key ID for SigV4 signing. When omitted, the standard AWS credential chain (environment, shared config, instance role) is used. Review Comment: Actually, let's put these under auth.sigv4. I'd like to move towards a world (which I'm trying to suggest in #127) where all auth fields are nested under `auth` and then the various sets go under that (sigv4, oauth, aws, etc) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
