plusplusjiajia commented on PR #118:
URL:
https://github.com/apache/terraform-provider-iceberg/pull/118#issuecomment-5884192741
@zeroshade Thanks a lot for the careful review, and for testing it against
a stub! Addressed, rebased on main:
- A missing region now errors for static and ambient credentials alike.
- Partial static keys error before anything is signed.
- Dropped the MinIO commit, isolated the AWS env in tests (including
`AWS_EC2_METADATA_DISABLED`), and merged the duplicate helper. The pairing
checks are now `stringvalidator.AlsoRequires`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]