rdblue commented on code in PR #17960:
URL: https://github.com/apache/iceberg/pull/17960#discussion_r4138114257
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -286,6 +291,9 @@ public static MetricsConfig from(Map<String, String> props,
Schema schema, SortO
// Override automatic modes with configured modes
columnModes.putAll(configuredColumnModes(props));
+ // Force full metrics for partition source columns
+ columnModes.putAll(partitionColumnModes(spec, schema));
Review Comment:
I agree with this. If we want to recover partition information, then we
cannot allow user config to override this. The content stats for these fields
becomes mandatory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
