amogh-jahagirdar commented on code in PR #17960:
URL: https://github.com/apache/iceberg/pull/17960#discussion_r4139218536
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -338,6 +346,24 @@ private static Map<String, MetricsMode>
configuredColumnModes(Map<String, String
return builder.build();
}
+ private static Map<String, MetricsMode> partitionColumnModes(PartitionSpec
spec, Schema schema) {
+ if (spec == null || schema == null) {
+ return ImmutableMap.of();
+ }
+
+ ImmutableMap.Builder<String, MetricsMode> builder = ImmutableMap.builder();
+ for (PartitionField field : spec.fields()) {
+ if (field.transform().preservesOrder()) {
+ String name = schema.findColumnName(field.sourceId());
+ Preconditions.checkArgument(
+ name != null, "Cannot find source column for partition field: %s",
field.name());
+ builder.put(name, MetricsModes.Full.get());
Review Comment:
Yeah, I thought about this and just kept it as full for simplicity. But yes
as an improvement we can allow for stats truncation to at least W as long as
partition values are taken from lower bounds. but that's just more complexity
at this point. I added a comment explaining why we're using full and suggesting
the improvement we could do in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
