amogh-jahagirdar commented on code in PR #16025: URL: https://github.com/apache/iceberg/pull/16025#discussion_r4138171567
########## format/spec.md: ########## @@ -1387,6 +1534,20 @@ At most one deletion vector is allowed per data file in a snapshot. If a DV is w [puffin-spec]: https://iceberg.apache.org/puffin-spec/ +#### Manifest Deletion Vectors Review Comment: I thin somewhere in here we should very briefly mention that manifest DVs may also be set on PRE-V4 manifest entries in the root. That's important to make sure we don't force additional write amplification when trying to produce combined entries into new V4 entries. At the moment, the spec doesn't explicitly restrict that, and nor should we but we should also make it clear that writers may choose to do that to prevent any confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
