rdblue commented on code in PR #18108:
URL: https://github.com/apache/iceberg/pull/18108#discussion_r4138368513
##########
core/src/main/java/org/apache/iceberg/TrackedFile.java:
##########
@@ -169,7 +169,10 @@ static Schema readSchema(Types.StructType partitionType,
Types.StructType conten
/** Returns the ID of the partition spec used to partition this file, or
null. */
Integer specId();
- /** Returns partition for this file as a {@link StructLike}, or null. */
+ /**
+ * Returns the partition for this file as a {@link StructLike} in the field
order of the file's
Review Comment:
I think field order makes this sound like order is the issue, but what this
needs to say is that the struct's type is the partition spec's output type. I
would rephrase this to:
> Return the partition for this file as a struct with the partition spec's
output type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
