anoopj commented on code in PR #18108:
URL: https://github.com/apache/iceberg/pull/18108#discussion_r4139837751
##########
core/src/main/java/org/apache/iceberg/TrackedFileAdapters.java:
##########
@@ -101,7 +101,8 @@ public int specId() {
@Override
public StructLike partition() {
- return file().partition() != null ? file().partition() :
PartitionData.EMPTY;
+ StructLike partition = file.partition();
+ return partition != null ? partition : PartitionData.EMPTY;
Review Comment:
It was not a no-op. The original code evaluated `file().partition()` twice,
and the change was to do it just once. I kept the single call but switched back
from the file field to the file() accessor to stay consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
