akashmalbari commented on code in PR #18299:
URL: https://github.com/apache/iceberg/pull/18299#discussion_r4144311173
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/sql/TestAggregatePushDown.java:
##########
@@ -94,6 +94,17 @@ public void
testDifferentDataTypesAggregatePushDownInNonPartitionedTable() {
testDifferentDataTypesAggregatePushDown(false);
}
+ @TestTemplate
+ public void testAggregatePushDownWithRowLineageMetadataColumn() {
+ sql("CREATE TABLE %s (id INT) USING iceberg TBLPROPERTIES
('format-version'='3')", tableName);
+ sql("INSERT INTO %s VALUES (1), (2), (3)", tableName);
+
+ List<Object[]> actual = sql("SELECT max(_row_id) FROM %s", tableName);
+
+ assertThat(actual).hasSize(1);
+ assertThat(actual.get(0)[0]).isInstanceOf(Long.class);
Review Comment:
Addressed in 3ec05b548. The Spark 4.1 and 4.2 tests now assert that
`max(_row_id)` is absent from the pushed-down plan and that the exact result is
`2L`. Both focused tests pass in all four catalog configurations, and both
module Spotless checks pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
