uros-b commented on code in PR #18317:
URL: https://github.com/apache/iceberg/pull/18317#discussion_r4144010489
##########
spark/v4.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestChangelogTable.java:
##########
@@ -290,6 +297,23 @@ public void testMetadataColumns() {
rows);
}
+ @TestTemplate
+ public void rowLineageMetadataColumnsInV3() {
Review Comment:
TestChangelogTable.rowLineageMetadataColumnsInV3 exercises only the INSERT
path. LAST_UPDATED_SEQUENCE_NUMBER is declared preserveOnDelete(false), meaning
DELETED changelog rows should return null for that column — but no test
verifies this asymmetry. The new code path is small and the column declaration
is clear, but this is a meaningful gap in the only V3 changelog-metadata test;
worth a quick DELETE-path assertion before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
