danielcweeks commented on code in PR #18329:
URL: https://github.com/apache/iceberg/pull/18329#discussion_r4149458464
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3InputStream.java:
##########
@@ -108,9 +107,17 @@ void testZeroLengthReadFullyDoesNotCountMetrics() throws
IOException {
// a zero-length readFully performs no real read; it must count neither
bytes nor an operation
assertThat(readBytes.value()).isEqualTo(0);
assertThat(readOperations.value()).isEqualTo(0);
+ verifyNoInteractions(s3Client);
Review Comment:
This really shouldn't be part of this particular test. We're not testing
that it doesn't perform an operation, but we're sneaking that validation in
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
