AlejandroMorgante commented on code in PR #18329:
URL: https://github.com/apache/iceberg/pull/18329#discussion_r4149504120


##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3InputStream.java:
##########
@@ -108,9 +107,17 @@ void testZeroLengthReadFullyDoesNotCountMetrics() throws 
IOException {
       // a zero-length readFully performs no real read; it must count neither 
bytes nor an operation
       assertThat(readBytes.value()).isEqualTo(0);
       assertThat(readOperations.value()).isEqualTo(0);
+      verifyNoInteractions(s3Client);

Review Comment:
   Thanks! I moved the S3 interaction assertion into its own test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to