dilipbiswal commented on a change in pull request #1947:
URL: https://github.com/apache/iceberg/pull/1947#discussion_r559837157
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/utils/RewriteRowLevelOperationHelper.scala
##########
@@ -54,12 +54,12 @@ trait RewriteRowLevelOperationHelper extends
PredicateHelper with Logging {
table: Table,
tableAttrs: Seq[AttributeReference],
mergeBuilder: MergeBuilder,
- cond: Expression,
+ cond: Option[Expression] = None,
matchingRowsPlanBuilder: DataSourceV2ScanRelation => LogicalPlan):
LogicalPlan = {
val scanBuilder = mergeBuilder.asScanBuilder
- pushFilters(scanBuilder, cond, tableAttrs)
+ cond.map(pushFilters(scanBuilder, _, tableAttrs))
Review comment:
@rdblue ok.. i will change it for now. We will discuss the deterministic
thing later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
