nastra commented on code in PR #18249:
URL: https://github.com/apache/iceberg/pull/18249#discussion_r4152565109
##########
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/mock/AliyunOSSMockExtension.java:
##########
@@ -65,11 +66,8 @@ public void stop() {
@Override
public OSS createOSSClient() {
- String endpoint =
- String.format(
- "http://localhost:%s";,
- properties.getOrDefault(
- AliyunOSSMock.PROP_HTTP_PORT,
AliyunOSSMock.PORT_HTTP_PORT_DEFAULT));
+ Preconditions.checkNotNull(ossMock, "OSS Mock must be started before
creating a client");
Review Comment:
```suggestion
Preconditions.checkState(null != ossMock, "OSS Mock must be started
before creating a client");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
